feat: add predicate leaf functions#33
Conversation
|
Thanks @SteNicholas for contributing the string-pattern predicate operators ( |
leaves12138
left a comment
leaves12138
left a comment
There was a problem hiding this comment.
Reviewed the updated predicate leaf function implementations. The LIKE matcher fix looks good, and the comparison, null, IN/NOT_IN, compound, and string predicate semantics match the Java behavior I checked. Given that tests and public construction entry points will be submitted in the follow-up PR to keep this one focused, I do not see blockers for this PR.
leaves12138
left a comment
leaves12138
left a comment
There was a problem hiding this comment.
Reviewed the latest head. The follow-up LIKE error formatting/emplace cleanup looks good, and I did not find new blockers.
2 participants
Purpose
No Linked issue.
Introduce concrete
LeafFunctionandCompoundFunctionimplementations for all predicate operators:Equal,NotEqual,GreaterThan,GreaterOrEqual,LessThan,LessOrEqualIn,NotInIsNull,IsNotNullAnd,OrLike,Contains,StartsWith,EndsWithEach operator provides
Test()overloads for per-row evaluation, batch (Arrow array) evaluation, and min/max stats-based file skipping.Tests
API and Format
Documentation
Generative AI tooling
Migrate-by: Aone Copilot (Claude)